Merged
Conversation
…ies/com.unity.netcode.gameobjects into feat/session-state-token
EmandM
reviewed
Feb 5, 2025
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
Is this SessionStateToken intended to be used outside of DistributedAuthority? If not, the token should go in the ServiceConfig rather than in the ConnectionApproval message itself
EmandM
approved these changes
Apr 7, 2025
Member
|
Shouldn't we add this change to the CHANGELOG file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/MTT-10043
https://docs.google.com/document/d/1st5PoxRa7rg5JsLW0pKbVAgaqBP1QdUCx2gFlHXEicg/edit?tab=t.0
Adding a SessionStateToken to the ConnectionApproved message and incrementing the version. This is safe without implementing the feature as the service does not need to make any assumptions about what the client does with this information.
Changelog
Testing and Documentation
Related PR
https://github.com/Unity-Technologies/mps-common-multiplayer-backend/pull/976